Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Change diagnostic position from pos(start) to range(start, end) #638

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 2, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

errors

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Change diagnostic position from pos(start) to range(start, end)

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link
Collaborator

coveralls commented Aug 2, 2023

Pull Request Test Coverage Report for Build 5780664246

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5760851874: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@He1pa He1pa force-pushed the feat_diag_pos_to_range branch 2 times, most recently from 488d070 to 7dbb090 Compare August 2, 2023 10:07
@Peefy Peefy changed the title feat: change position of diag. Change the position of diagnostic from… feat: change position of diag. Change the position of diagnostic from pos(start) to range(start, end) Aug 2, 2023
@Peefy Peefy added the lsp label Aug 2, 2023
@He1pa He1pa changed the title feat: change position of diag. Change the position of diagnostic from pos(start) to range(start, end) Feat: Change diagnostic position from pos(start) to range(start, end) Aug 3, 2023
@He1pa He1pa self-assigned this Aug 3, 2023
@He1pa He1pa marked this pull request as ready for review August 3, 2023 02:58
kclvm/error/src/diagnostic.rs Outdated Show resolved Hide resolved
kclvm/error/src/diagnostic.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 939c2ff into kcl-lang:main Aug 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants